Feat/preview missing status#1103
Merged
Merged
Conversation
Add a new `missing` PreviewFile status that means "the source movie is gone from storage, so renormalization is no longer possible". Until now, both irrecoverable rows and genuine encode failures were lumped together as `broken`, leaving operators no way to retry only the recoverable ones and forcing them to keep hitting Swift 404s on every renormalize pass. The new status is persisted via SQLAlchemy ChoiceType (no DB CHECK constraint, no migration), and exposed verbatim through the API and serialization helpers so the wire format gains a new value. `zou renormalize-movie-preview-files`: - Mark renormalization failures so rows do not stay in `processing` forever: source-binary-missing now sets `missing`, every other failure keeps setting `broken`. - Add `--all-missing` next to `--all-broken` and `--all-processing`, so each status can be targeted independently. `--all-broken` no longer touches `missing` rows. `zou sync-full-files`: - Add `--skip-broken` and `--skip-missing` so operators can exclude unusable previews from large pulls; defaults preserve previous behavior of syncing every row. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
nledez
force-pushed
the
feat/preview-missing-status
branch
from
f51007d to
872825e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
renormalize pass had given up.
whose source binary is simply gone from object storage. Operators could not target the irrecoverable rows without retrying the recoverable ones too.
Solution
this no longer stays as processing.
and present_minimal() so existing API/Kitsu clients see no change. This flag is intentionally temporary: it gives us time to (1) announce the new status publicly, (2) ship the
matching Kitsu UI/UX changes, and (3) let third-party clients adopt. Once Kitsu speaks missing natively, EXPOSE_MISSING will be removed and missing will be surfaced
unconditionally.
escape hatch to retry rows whose source has since been restored.
as broken for "needs attention" purposes.